[Bro-Dev] #636: topic/jsiwek/comphash-func-determinism

Bro Tracker bro at tracker.bro-ids.org
Thu Oct 6 08:36:13 PDT 2011


#636: topic/jsiwek/comphash-func-determinism
----------------------------+------------------------
  Reporter:  jsiwek         |      Owner:  jsiwek
      Type:  Merge Request  |     Status:  assigned
  Priority:  Normal         |  Milestone:
 Component:  Bro            |    Version:  git/master
Resolution:                 |   Keywords:
----------------------------+------------------------

Comment (by robin):

 On Thu, Oct 06, 2011 at 15:04 -0000, you wrote:

 >  Per the goal above I thought we said it has to work even outside of
 >  seeded-mode?

 Hmm, I must have missed that part of the discussion. But makes sense.

 Here's another thought: rather than assigning IDs to all functions
 that don't have one yet, what about just enumerating them internally
 with an integer? Each function gets a new "int unique_func_id" and we
 just keep incrementing it. Then we use that for hashing. As we don't
 have many functions, having the additional field won't matter; but
 different than the IDs, it doesn't have any user-visible effects and
 doesn't need support in the parser (the Function ctor can do that
 internally and also keep a static vector of id->ptr).

 Robin

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/636#comment:4>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker



More information about the bro-dev mailing list