[Bro-Dev] #808: topic/icmp6

[Bro Tracker]

#808: topic/icmp6
----------------------------+------------------------
  Reporter:  jsiwek         |      Owner:  robin
      Type:  Merge Request  |     Status:  closed
  Priority:  Normal         |  Milestone:  Bro2.1
 Component:  Bro            |    Version:  git/master
Resolution:  fixed          |   Keywords:
----------------------------+------------------------

Comment (by jsiwek):

 Replying to [comment:2 robin]:
 > One question though: In {{{ICMP_Analyzer::RouterAdvert}}}:
 >
 > {{{
 > vl->append(new Val(htons(icmpp->icmp_lifetime), TYPE_COUNT));
 > vl->append(new Val(reachable, TYPE_INTERVAL));
 > vl->append(new Val(retrans, TYPE_INTERVAL));
 > }}}
 >
 > These don't look right.
 >
 > (1) Is hton really correct for the lifetime? Should the lifetime be of
 TYPE_INTERVAL as well?
 > (2) TYPE_INTERVAL must be initialized with doubles, not with uint32; and
 it's needs seconds, not ms, as I believe the reachable/retrans fields
 record, don't they?
 >
 >
 > (Merging it as it is, please commit fixes to fast path as appropriate
 and then close this ticket).

 Good catches, I'll take a closer look at this.

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/808#comment:4>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker