[Bro-Dev] Hui Lin_Merging DNP3 analyzer

[Hui Lin (Hugo)]

On Wed, Aug 1, 2012 at 5:49 PM, Robin Sommer <robin at icir.org> wrote:

> Hui, what's the branch your most recent code is in?
>
 I am working on the branch  topic/hui/powergrid3
But I have not pushed my recent modifications.


> On Wed, Aug 01, 2012 at 10:50 -0500, you wrote:
>
> > 1. I have some customization codes in DNP3.cc. I simply printf the error
> > message in this file (such as memory allocation failed). For those error
> > messages, do I have to include them in log files ?
>
> Yes, you should use the reporter for errors. For memory in particular,
> you don't need to check if you use "new" (because a handler for that
> is installed), and there's safe_malloc etc. for the C-style functions
> (see util.h)
>

Do we have any macro for reporting errors? There are some other errors in
addition to memory allocation.

I may need some time to replace that old malloc functiions with the safe
ones.


>
> > 2. where should I put several sample policy files?
>
> Put them under scripts/policy/protocols/ for now, we can later see if
> that's something we want to ship.
>
OK.
I also plan to add little explanations on those policies.


>
> Robin
>
> --
> Robin Sommer * Phone +1 (510) 722-6541 * robin at icir.org
> ICSI/LBNL    * Fax   +1 (510) 666-2956 *   www.icir.org
>



-- 
Hui Lin
PhD Candidate, Research Assistant
Electrical and Computer Engineering Department
University of Illinois at Urbana-Champaign
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.icsi.berkeley.edu/pipermail/bro-dev/attachments/20120801/abdaca7c/attachment.html