[Bro-Dev] A consistent order of precedence for broctl options

Robin Sommer robin at icir.org
Tue Aug 21 08:23:28 PDT 2012


On Mon, Aug 20, 2012 at 17:06 +0000, Adam wrote:

> I hope we can at least agree on two points. First, there should be a
> well-defined precedence that is documented and followed as uniformly
> as possible.

Agreed.

>  If you're on board with that, do you agree with my second assertion
>  that broctl should get the last word and override all others?

Yeah, agreed as well, though somewhat reluctantly. :) What I wrote in
http://tracker.bro-ids.org/bro/ticket/837#comment:7 would work as well
I think[1], but it doesn't really look worth the effort. 

[1] Could be done by printing out the values and compare with what
BroControl would expect.

On Mon, Aug 20, 2012 at 13:48 -0500, Daniel wrote:

> "Site-specific Customization" section), but it might also be
> useful to add a note in the "Option Reference" section for each
> broctl option that can be set via a bro script variable (for example,
> "this option overrides the bro script variable 
> 'default_rotation_interval'").

We should then also do that the other way: add a note to the script
doc saying that if using BroControl, it will override the value with
its option.

And yeah, renaming the options to be consistent would be good too
then.

So, I'm on board. :)

Robin

-- 
Robin Sommer * Phone +1 (510) 722-6541 * robin at icir.org
ICSI/LBNL    * Fax   +1 (510) 666-2956 *   www.icir.org


More information about the bro-dev mailing list