[Bro-Dev] new IPv6 code
seth at icir.org
Wed Feb 15 13:19:27 PST 2012
On Feb 15, 2012, at 4:09 PM, Robin Sommer wrote:
> - PktSrc.cc:
> - protocol = (data << 24) + (data << 16) + (data << 8) + data;
> + protocol = (data << 24) + (data << 16) + (data << 8) + data;
> Does that mean this was buggy before?
(I did that). It seems like it was, but Jon pointed out that it may still be wrong if that 32bit int is supposed to be in a defined byte order. It was broken for me on Mac OS X at least with some IPv6 packets I had that used the loopback interface.
Jon did also point out that it probably shouldn't have been fixed in the v6 branch which made sense to me after I had already committed it. :)
International Computer Science Institute
(Bro) because everyone has a network
More information about the bro-dev