[Bro-Dev] #775: IP address parsing more strict with new IPv6 code
Bro Tracker
bro at tracker.bro-ids.org
Wed Feb 22 05:29:29 PST 2012
#775: IP address parsing more strict with new IPv6 code
----------------------+------------------------
Reporter: robin | Owner: jsiwek
Type: Problem | Status: reopened
Priority: Normal | Milestone:
Component: Bro | Version: git/master
Resolution: | Keywords: ipv6
----------------------+------------------------
Changes (by robin):
* status: closed => reopened
* resolution: fixed =>
Comment:
I'm merging this in, but the CanonIPv4() function looks overly
complex/expensive. Would it be better to just parse the IP address
ourselves (rather than splitting the string, then reassemble, to then
parse via the C library? Or, alternatively, we could build at least a fast
path into CanonIPv4() which triggers splitting only when there are
actually any leading zeros (that would be a quick string search).
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/775#comment:2>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
More information about the bro-dev
mailing list