[Bro-Dev] #786: Minor bugfixes

Bro Tracker bro at tracker.bro-ids.org
Fri Feb 24 16:38:29 PST 2012


#786: Minor bugfixes
----------------------------+------------------------
  Reporter:  JulienSentier  |      Owner:
      Type:  Patch          |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  Bro            |    Version:  git/master
Resolution:                 |   Keywords:
----------------------------+------------------------

Comment (by robin):

 Applied these (with a few further tweaks). Thanks! Out of curiosity, how
 did you find these?

 The one change I don't understand is this:

 {{{
 --- a/src/SMTP.cc
 +++ b/src/SMTP.cc
 @@ -353,7 +353,6 @@ void SMTP_Analyzer::ProcessLine(int length, const
 char* line, bool orig)
                         int ext_len;

                         get_word(end_of_line - line, line, ext_len, ext);
 -                       line = skip_whitespace(line + ext_len,
 end_of_line);
                         ProcessExtension(ext_len, ext);
                         }
                 }

 }}}

 Why is that dead code?

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/786#comment:1>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker



More information about the bro-dev mailing list