[Bro-Dev] #740: Bug resulting in too many internal type references

[Bro Tracker]

#740: Bug resulting in too many internal type references
----------------------+--------------------
  Reporter:  seth     |      Owner:
      Type:  Problem  |     Status:  new
  Priority:  Normal   |  Milestone:  Bro2.0
 Component:  Bro      |    Version:
Resolution:           |   Keywords:
----------------------+--------------------

Comment (by seth):

 > This sounds like a plain ref counting bug to me. The caller should
 > unref once it doesn't need the type anymore. Were you able to
 > understand which caller isn't doing it?  It doesn't need to be the on
 > the stack backtrace (and from a quick look, it isn't).

 There are only a few places outside of NetVar.cc that even call
 internal_type which is why I made the consistency comment.  You can find
 everywhere that causes this ref counting problem with a quick grep since
 there aren't that many, especially if you count out the stuff in
 NetVar.cc.

 And I caused this bug (/me ducks).

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/740#comment:2>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker