[Bro-Dev] #762: Add eof line to logfiles

[G. Clark]

Nope, the headers aren't RFC spec, either.  IIRC, the option to disable 
these headers is (from scripts/base/frameworks/logging/writers/ascii.bro):

     ## If true, include a header line with column names and description
     ## of the other ASCII logging options that were used.
     const include_header = T &redef;

Thus, `include_footer` seems like it'd be sane to me.

--Gilbert

On 1/30/12 8:22 PM, Bernhard Amann wrote:
> It would not be CSV compatible, that is true… but Bro already uses the same format for its header lines (which also are not RFC 4180 conformant unless I am very much mistaken).
>
> Can those be switched off by a configuration option? If yes one could use the same one for the footer line...
>
> On Jan 30, 2012, at 5:13 PM, G. Clark wrote:
>
>> AFAIK, RFC 4180 doesn't specify comments as part of standard CSV format.  Thus, I believe it's important to ensure that an option to disable this behavior makes it into the code.
>>
>> --Gilbert
>>
>> On 1/30/12 6:41 PM, Bro Tracker wrote:
>>> #762: Add eof line to logfiles
>>> ------------------------------+------------------------
>>>    Reporter:  amannb           |      Owner:
>>>        Type:  Feature Request  |     Status:  new
>>>    Priority:  Normal           |  Milestone:
>>>   Component:  Bro              |    Version:  git/master
>>> Resolution:                   |   Keywords:
>>> ------------------------------+------------------------
>>>
>>> Comment (by robin):
>>>
>>>   On Mon, Jan 30, 2012 at 23:17 -0000, you wrote:
>>>
>>>   >    #EOF
>>>
>>>   That makes sense I think.
>>>
>>>   Robin
>>>
>>
>>
>> _______________________________________________
>> bro-dev mailing list
>> bro-dev at bro-ids.org
>> http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6010 bytes
Desc: S/MIME Cryptographic Signature
Url : http://mailman.icsi.berkeley.edu/pipermail/bro-dev/attachments/20120130/a4b85872/attachment.bin