[Bro-Dev] #763: Escape # when first character in log file line

Bro Tracker bro at tracker.bro-ids.org
Fri Jul 20 09:28:30 PDT 2012


#763: Escape # when first character in log file line
----------------------+------------------------
  Reporter:  amannb   |      Owner:  robin
      Type:  Problem  |     Status:  closed
  Priority:  High     |  Milestone:  Bro2.2
 Component:  Bro      |    Version:  git/master
Resolution:  fixed    |   Keywords:
----------------------+------------------------

Comment (by robin):

 In [f7a6407ab1213d95f074e47c39061f541f630944/bro]:
 {{{
 #!CommitTicketReference repository="bro"
 revision="f7a6407ab1213d95f074e47c39061f541f630944"
 Reworking thread termination logic.

 Turns out the finish methods weren't called correctly, caused by a
 mess up with method names which all sounded too similar and the wrong
 one ended up being called. I've reworked this by changing the
 thread/writer/reader interfaces, which actually also simplifies them
 by getting rid of the requirement for writer backends to call their
 parent methods (i.e., less opportunity for errors).

 This commit also includes the following (because I noticed the problem
 above when working on some of these):

      - The ASCII log writer now includes "#start <timestamp>" and
       "#end <timestamp> lines in the each file. The latter supersedes
       Bernhard's "EOF" patch.

       This required a number of tests updates. The standard canonifier
       removes the timestamps, but some tests compare files directly,
       which doesn't work if they aren't printing out the same
       timestamps (like the comm tests).

      - The above required yet another change to the writer API to
        network_time to methods.

      - Renamed ASCII logger "header" options to "meta".

      - Fixes #763 "Escape # when first character in log file line".

 All btests pass for me on Linux FC15. Will try MacOS next.
 }}}

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/763#comment:7>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker



More information about the bro-dev mailing list