[Bro-Dev] #860: Rotation trouble

Bro Tracker bro at tracker.bro-ids.org
Sat Jul 28 11:31:56 PDT 2012

#860: Rotation trouble
  Reporter:  robin          |      Owner:
      Type:  Merge Request  |     Status:  new
  Priority:  High           |  Milestone:  Bro2.1
 Component:  Bro            |    Version:  git/master
Resolution:                 |   Keywords:

Comment (by robin):

 The fix makes sense, but the interface gets a bit confusing with the two
 rotation-done methods. Also, do the writers actuallt  need to call the
 FailedRotation() method when FinishedRotation() returns false? While
 FinishedRotation() currently always returns true anyways, even if it
 didn't, it could just call FailedRotation() itself.

 Here's a suggestion: what if we instead of adding FailedRotation(), we
 instead added a "success" parameter to FinishedRotation(). If false, it
 would just decrease the rotation count on the manager side, but don't do
 anything else.

Ticket URL: <http://tracker.bro-ids.org/bro/ticket/860#comment:4>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker

More information about the bro-dev mailing list