[Bro-Dev] #825: topic/dnthayer/bif-tests

[Bro Tracker]

#825: topic/dnthayer/bif-tests
---------------------------+------------------------
 Reporter:  dnthayer       |      Owner:
     Type:  Merge Request  |     Status:  new
 Priority:  Normal         |  Milestone:  Bro2.1
Component:  Bro            |    Version:  git/master
 Keywords:                 |
---------------------------+------------------------
 On this branch I have added tests for many previously-untested BIFs.

 In the process I found and fixed some bugs:  "join_string_vec"
 was broken and is now fixed, the data type of 2nd argument
 of "system_env" has been changed from "any" to
 "table_string_of_string" because that is the only type that
 seems to work, and "parse_dotted_addr" has been deprecated.
 I've also improved or fixed the documentation comments for
 several BIFs.

 There are still a few unresolved issues (marked with "TODO"
 comments in the test code):
 1) the "order" BIF doesn't seem to work correctly (the results
  appear inconsistent and don't make sense to me),
 2) the "type_name" BIF always returns "vector" for vector types
  (I would expect a more precise result, similar to the results
  it gives for sets and tables), and it gives perhaps an overly
  precise result ("file of string") for file types,
 3) the documentation comments for "fmt" claim that you can
  specify a non-string as the first argument (in which case
  it's supposed to concatenate all the arguments, like "cat"),
  but it rejects non-string first arguments.

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/825>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker