[Bro-Dev] #837: broctl load order incorrect

[Bro Tracker]

#837: broctl load order incorrect
-------------------------+------------------------
  Reporter:  seth        |      Owner:  dnthayer
      Type:  Problem     |     Status:  new
  Priority:  Normal      |  Milestone:  Bro2.1
 Component:  BroControl  |    Version:  git/master
Resolution:              |   Keywords:
-------------------------+------------------------

Comment (by dnthayer):

 Replying to [comment:1 seth]:
 > Hm, this is a little more complicated than I first remembered.  The
 problem is that this is an option that is potentially set by broctl.
 >
 > logrotationinterval
 >
 > Of course, if I set something directly in a bro script I would like for
 broctl to not overwrite that setting.  I vote for changing the order and
 keeping more advanced users happy that might be setting this stuff
 directly.

 I would think that the broctl setting should take priority, because
 I want to be able to trust the output of "broctl config".  Otherwise,
 if a bro script could override it, then I'd have to check the broctl
 source code to find the name of the script variable (for
 broctl option "logrotationinterval", the bro script variable
 name is "default_rotation_interval").  Then, if I do a
 "grep -R default_rotation_interval *" in the install tree, I see
 it assigned 4 different values in 8 different places.

 Alternatively, how about we just remove those broctl options
 that clash with bro script variables?  I guess as long as we
 have multiple ways of setting a single parameter it will
 inevitably lead to confusion.

 Looking at the broctl README, I see some factual errors in
 the "Site-specific Customization" section. I will try to
 clarify the instructions there.

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/837#comment:2>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker