[Bro-Dev] #819: topic/dnthayer/icmp-error-message

[Bro Tracker]

#819: topic/dnthayer/icmp-error-message
----------------------------+------------------------
  Reporter:  dnthayer       |      Owner:  robin
      Type:  Merge Request  |     Status:  closed
  Priority:  Normal         |  Milestone:  Bro2.1
 Component:  Bro            |    Version:  git/master
Resolution:  fixed          |   Keywords:  ipv6
----------------------------+------------------------

Comment (by dnthayer):

 Replying to [comment:1 robin]:
 > Merged, but for my education, what's this testing for:
 >
 > {{{
 > if ( icmpp->icmp_type < 128 )
 > }}}
 >
 > I.e., where's the magic 128 coming from?
 >
 >

 Sorry, I should have added a comment in the code explaining that.
 This is now done in fastpath (I basically just copied the comment
 that is 35 lines above, and added a note about the 128).

-- 
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/819#comment:4>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker