[Bro-Dev] [JIRA] (BIT-1050) Merge request for DHCP analyzer

Robin Sommer (JIRA) jira at bro-tracker.atlassian.net
Sat Aug 3 21:17:06 PDT 2013

    [ https://bro-tracker.atlassian.net/browse/BIT-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423#comment-13423 ] 

Robin Sommer commented on BIT-1050:

Nice. I've merged this with some small changes. Notes:

- I'm not sure I like the structure with the two policy scripts. As we don't have anything else extracting MAC addresses currently, would it make sense to just move them into one? If not, I'd at least move the one out of misc, and also change the interface so that (1) users don't manipulate the table directly (but call functions instead), and (2) the logging stays internal to the script (the same functions could take care of that). But I'll let Seth take a look at this (or has he already?), assigning ticket to him.

- format_mac(): The comment says "Supports both EUI-48 and EUI-64. If it's neither, returns an empty string.". That didn't seem to match the code, which always passed back something. I've changed the function to take a length parameter, just  assuming its long enough makes me uneasy. So now if less bytes are passed in, it returns the empty string the comment promises. :) Also, moved to net_utils as fmt_mac().

- A note for the future: you changed quite a bit of white space/formatting in existing code, which makes reading the diff very hard. Please try to keep things unmodified where you don't make changes.
> Merge request for DHCP analyzer
> -------------------------------
>                 Key: BIT-1050
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1050
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>    Affects Versions: 2.2
>            Reporter: Vlad Grigorescu
>            Assignee: Seth Hall
>              Labels: analyzer
> topic/vladg/dhcp is ready to go. I've been running it in prod with no problems.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

More information about the bro-dev mailing list