[Bro-Dev] [JIRA] (BIT-1050) Merge request for DHCP analyzer

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426#comment-13426 ] 

Robin Sommer commented on BIT-1050:
-----------------------------------





It could also log an update when it gets more information than logged
last time. However I'd vote for just combining the two scripts into
one for now until we have that other script and can flesh out the
interface.


I think it's a mix of different ones, I call it "Vern style". :) A
separate commit that changes just formatting would definitly be better
for such changes (it wasn't just whitespace, sometimes braces moved so
that git's white-space-ignore still reported them).

Generally, I don't think it's worth too much attention for existing
code. I'm hoping we'll eventually have a tool that formats things into
a consistent style automatically (I have been playing with
clang-format a bit, I think that might work).


                
> Merge request for DHCP analyzer
> -------------------------------
>
>                 Key: BIT-1050
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1050
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>    Affects Versions: 2.2
>            Reporter: Vlad Grigorescu
>            Assignee: Seth Hall
>              Labels: analyzer
>
> topic/vladg/dhcp is ready to go. I've been running it in prod with no problems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira