[Bro-Dev] [Bro-Commits] [git/bro] topic/matthias/bloom-filter: Fixing for unserializion error. (40201a1)

Robin Sommer robin at icir.org
Wed Jul 10 07:34:35 PDT 2013



On Wed, Jul 10, 2013 at 10:27 +0200, you wrote:

> I assume this is only necessary when serializing through the base
> class?

Indeed.

>  For example, we have another serializable base class HashVal with
>  derived classes for MD5, SHA1, etc., but never use the class
>  instances in a polymorphic context.

HashVal is derived from Val, so that should be fine as long as
unserializing is triggered via Val::Unserialize(). A good rule of
thumb for this treatment is base classes that come with their own
Unserialize() method.

Robin

-- 
Robin Sommer * Phone +1 (510) 722-6541 *     robin at icir.org
ICSI/LBNL    * Fax   +1 (510) 666-2956 * www.icir.org/robin


More information about the bro-dev mailing list