[Bro-Dev] [Bro-Commits] [git/bro] fastpath: Fixed a scriptland state issue that manifested especially badly on proxies. (5c3bf14)

[Siwek, Jonathan Luke]

What was the issue?  Maybe I'm reading the diff wrong, but the membership check should be implicit in the delete statement, so this change shouldn't function differently?  Or if it actually does, then there's probably still a bug in the core code.

- Jon

On Jul 22, 2013, at 1:06 PM, Seth Hall <seth at icir.org> wrote:

> Repository : ssh://git@bro-ids.icir.org/bro
> 
> On branch  : fastpath
> Link       : http://tracker.bro-ids.org/bro/changeset/5c3bf14d168cca9af75e0ac642de8049f89cf525/bro
> 
>> ---------------------------------------------------------------
> 
> commit 5c3bf14d168cca9af75e0ac642de8049f89cf525
> Author: Seth Hall <seth at icir.org>
> Date:   Mon Jul 22 14:02:56 2013 -0400
> 
>    Fixed a scriptland state issue that manifested especially badly on proxies.
> 
> 
>> ---------------------------------------------------------------
> 
> 5c3bf14d168cca9af75e0ac642de8049f89cf525
> scripts/base/protocols/irc/dcc-send.bro | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/base/protocols/irc/dcc-send.bro b/scripts/base/protocols/irc/dcc-send.bro
> index 0a7f27e..3194766 100644
> --- a/scripts/base/protocols/irc/dcc-send.bro
> +++ b/scripts/base/protocols/irc/dcc-send.bro
> @@ -185,5 +185,6 @@ event expected_connection_seen(c: connection, a: Analyzer::Tag) &priority=10
> 
> event connection_state_remove(c: connection) &priority=-5
> 	{
> -	delete dcc_expected_transfers[c$id$resp_h, c$id$resp_p];
> +	if ( [c$id$resp_h, c$id$resp_p] in dcc_expected_transfers )
> +		delete dcc_expected_transfers[c$id$resp_h, c$id$resp_p];
> 	}
> 
> _______________________________________________
> bro-commits mailing list
> bro-commits at bro.org
> http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-commits
>