[Bro-Dev] #1010: BroControl plugin for adding environment variables

[Bro Tracker]

#1010: BroControl plugin for adding environment variables
-------------------------+------------------------
  Reporter:  seth        |      Owner:  dnthayer
      Type:  Task        |     Status:  assigned
  Priority:  Medium      |  Milestone:  Bro2.2
 Component:  BroControl  |    Version:  git/master
Resolution:              |   Keywords:
-------------------------+------------------------
Changes (by robin):

 * owner:  robin => dnthayer
 * type:  Merge Request => Task


Comment:

 Questions/requests:

 - there's code to remove quotes, but that seems to work only if there's
 just a single variable in the env_vars (i.e., not if individual variables
 are quoted). Is that intended? What's the situation here that's addressed,
 i.e, why would there be quotes in the first place?

 -  I suggest changing  the node's {{{env_vars}}} to a dictionary
 internally. Maintaining the space-separated list seems error-prone, in
 particular when plugins modify it. {{{_makeEnvParams()}}} would then build
 the string. That could also solve the quotation problem.

 - Actually another way to do this would be not passing all the variables
 on the command line, but installing them into the process environment
 before we spawn the child process. Not a must for this patch, but
 something to consider.

 - the Myricom plugin is overriding the existing variables, that should
 probably be adding to them instead?

 - I'm not seeing the  {{{broctl.cfg}}} option?

 - The option documentation should specify the format.

-- 
Ticket URL: <http://tracker.bro.org/bro/ticket/1010#comment:8>
Bro Tracker <http://tracker.bro.org/bro>
Bro Issue Tracker