[Bro-Dev] [JIRA] (BIT-1010) BroControl plugin for adding environment variables

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406#comment-13406 ] 

Robin Sommer commented on BIT-1010:
-----------------------------------

I like the idea of specifying the variables separately, putting it all in one line seems very fragile. How about this syntax:

{code}
env:VAR1=1
env:VAR2=2
{code}

I believe the parser should support that, no? We would just iterate through all entries and pick out those starting with {{env:}}.
Same for {{broctl.cfg}}.

Regarding the Myricom, I didn't compare with PF_RING, I just noticed that it seems to override any previously set value rather than adding to it. If node.cfg has priority, that's the most important thing, but still it seems fragile because if other parts of the code had set a (different) environment variable before, the plugin would override that. So all I suggest is making that {{+=}},
                
> BroControl plugin for adding environment variables
> --------------------------------------------------
>
>                 Key: BIT-1010
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1010
>             Project: Bro Issue Tracker
>          Issue Type: Task
>          Components: BroControl
>    Affects Versions: git/master
>            Reporter: Seth Hall
>            Assignee: Daniel Thayer
>             Fix For: 2.2
>
>         Attachments: env_vars.py
>
>
> We should have the ability to add environment variables to Bro at start up time.  The option should be available globally in broctl.cfg and per-node in node.cfg.  The environments variables should be applied to the process with priority based on how specific the variable is applied (per-node variables defined after global variables so that the per-node variable is used).
> As a name suggestion for the configuration option: env_vars (same name in node.cfg and broctl.cfg).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira