[Bro-Dev] [JIRA] (BIT-920) Have broctl return useful exit codes

[Daniel Thayer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408#comment-13408 ] 

Daniel Thayer commented on BIT-920:
-----------------------------------

In branch topic/dnthayer/bug920, I've made some small fixes to the patch,
and added support to broctl commands that were missed by the original 
patch.  The only remaining issues I see are:

1) "broctl cron" always returns 0 (this might not matter, because
   the return value doesn't affect the emails that cron sends),
2) "broctl status" and "broctl top" return 0 if all bro nodes are running, 
   and returns 1 otherwise (to me, this seems inconsistent with the 
   other commands, where a non-zero return value indicates some 
   error occurred),
3) there is no mechanism to return non-zero for a command provided
   by a broctl plugin (such as "broctl ps.bro")

                
> Have broctl return useful exit codes
> ------------------------------------
>
>                 Key: BIT-920
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-920
>             Project: Bro Issue Tracker
>          Issue Type: Patch
>          Components: BroControl
>    Affects Versions: git/master
>            Reporter: grigorescu
>            Assignee: Daniel Thayer
>             Fix For: 2.2
>
>
> I've got a broctl branch here: https://github.com/grigorescu/broctl which aims to have it return a 0 or 1 exit code for most execution paths. My dive down this particular rabbit hole started when I wanted to have status return a non-zero exit code if a node had failed, but I tried to cover everything else while I was at it.
> If someone could double-check it, to make sure that I didn't miss anything, it'd be much appreciated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira