[Bro-Dev] [JIRA] (BIT-1010) BroControl plugin for adding environment variables

Daniel Thayer (JIRA) jira at bro-tracker.atlassian.net
Tue Jul 30 16:33:06 PDT 2013

    [ https://bro-tracker.atlassian.net/browse/BIT-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410#comment-13410 ] 

Daniel Thayer commented on BIT-1010:

We are using Python's ConfigParser to read the node.cfg file. It doesn't support the notion
of having multiple instances of a key in the same section (it ignores duplicates).  However,
I've just made a change (in branch topic/dnthayer/ticket1010) to make env_vars 
stored as a dictionary internally and I've added more error-checking of the user-supplied
list of environment variables, so that should help improve the situation.

Regarding the Myricom plugin, I didn't use "+=" because that would override the user's
values from node.cfg. Instead, I put the plugin's environment variables
at the beginning of the list (so that the user's values can override the
plugin's values).  However, env_vars has now been re-implemented as a dictionary,
so hopefully the code is easier to read.

> BroControl plugin for adding environment variables
> --------------------------------------------------
>                 Key: BIT-1010
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1010
>             Project: Bro Issue Tracker
>          Issue Type: Task
>          Components: BroControl
>    Affects Versions: git/master
>            Reporter: Seth Hall
>            Assignee: Daniel Thayer
>             Fix For: 2.2
>         Attachments: env_vars.py
> We should have the ability to add environment variables to Bro at start up time.  The option should be available globally in broctl.cfg and per-node in node.cfg.  The environments variables should be applied to the process with priority based on how specific the variable is applied (per-node variables defined after global variables so that the per-node variable is used).
> As a name suggestion for the configuration option: env_vars (same name in node.cfg and broctl.cfg).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://bro-tracker.atlassian.net/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

More information about the bro-dev mailing list