[Bro-Dev] #591: Time to finish collecting stats
Bro Tracker
bro at tracker.bro.org
Fri Mar 22 14:52:57 PDT 2013
#591: Time to finish collecting stats
----------------------------+------------------------
Reporter: seth | Owner: robin
Type: Merge Request | Status: assigned
Priority: Normal | Milestone: Bro2.2
Component: BroControl | Version: git/master
Resolution: | Keywords: beta
----------------------------+------------------------
Comment (by dnthayer):
Replying to [comment:3 seth]:
> I think I found the problem with this. This line in the update-stats
script:
>
> {{{
> cp ${statsdir}/meta.dat ${statsdir}/www
> }}}
>
> If the www directory doesn't already exist that line will copy the
meta.dat to a file named www. The script that runs right after that line
is a python script that tries to open a file in that directory and it
hangs if it's a file instead of a directory. One easy hack is to add a
slash on the end of the line so that it looks like this:
>
> {{{
> cp ${statsdir}/meta.dat ${statsdir}/www/
> }}}
>
> I went ahead and committed the fix in topic/seth/ticket-591
>
> I'm not sure if this completely addresses the problem or not though, but
I think it's worthwhile closing this ticket and we'll reopen it or open a
new one if the problem reappears (we may need to tell people to delete the
www file if they've ended up with that).
I noticed on my system that ${statsdir}/www was a file (not a directory).
However,
when I ran the stats-to-csv python script that you mention above, it
doesn't
hang, but rather it's just terminated immediately by an uncaught
exception.
So, your fix works (as long as users first delete the "www" file), in the
sense that it prevents the creation of the "www" file, but I don't
think it addresses the problem in this bug (which I'm guessing is
caused by a hanging capstats command).
--
Ticket URL: <http://tracker.bro.org/bro/ticket/591#comment:5>
Bro Tracker <http://tracker.bro.org/bro>
Bro Issue Tracker
More information about the bro-dev
mailing list