[Bro-Dev] [Auto] Merge Status

Siwek, Jonathan Luke jsiwek at illinois.edu
Mon Nov 18 11:28:36 PST 2013

On Nov 18, 2013, at 9:52 AM, Robin Sommer <robin at icir.org> wrote:

> On Mon, Nov 18, 2013 at 00:00 -0800, you wrote:
>> 3effe5d [1]  bro          Daniel Thayer  2013-11-15  Update local.bro for Bro 2.2
> Daniel, rathter than simply removing the piece of code, can we put in
> a 2.2 version instead to achieve the same effect?

Even though the example would be commented out, that's defying the “best practice” of the only code in local.bro being @loads — it generally simplifies the upgrade procedure both for a user that wants to use the new upstream version and for a dev/maintainer that wants to set new defaults for things.

Maybe putting the example closer to the Notice::policy documentation (either within the Broxygen comments or the general Notice Framework docs) is better.  There, it’s easier to regression test, more likely to be changed if a dev makes incompatible changes to notice scripts, and more accessible to users.

- Jon

More information about the bro-dev mailing list