[Bro-Dev] [JIRA] (BIT-1087) topic/dnthayer/broctl-fixes

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201#comment-14201 ] 

Robin Sommer commented on BIT-1087:
-----------------------------------

This all makes sense, however some of the fixes make me wary to apply between beta and release as I can't really tell by just looking at them if they'll work correctly everywhere.  I suppose you have you tested these all on the major platforms? 

Does our test suite cover them so that we'd catch if something breaks on one of the tested platforms? If/where not, can you add tests that exercise the changed code paths (probably not easily possible everywhere, but for some).


> topic/dnthayer/broctl-fixes
> ---------------------------
>
>                 Key: BIT-1087
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1087
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: BroControl
>            Reporter: Daniel Thayer
>             Fix For: 2.2
>
>
> This branch fixes several bugs in broctl:
> 1) on Linux, the broctl "top" command output sometimes shows wrong values for memory statistics,
> 2) there is a race condition when the "sendmail" option is an empty string,
> 3) there is a deadlock when broctl runs a local command that produces a sufficiently large amount of output,
> 4) the shell scripts used by broctl are not as portable as they could be (specifically, some commands, such as sed, do not support the same options on all implementations)



--
This message was sent by Atlassian JIRA
(v6.1-OD-09-WN#6144)