[Bro-Dev] [JIRA] (BIT-1087) topic/dnthayer/broctl-fixes

Daniel Thayer (JIRA) jira at bro-tracker.atlassian.net
Thu Oct 10 08:51:28 PDT 2013


    [ https://bro-tracker.atlassian.net/browse/BIT-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204#comment-14204 ] 

Daniel Thayer commented on BIT-1087:
------------------------------------

We already have test coverage for items #2 and #4 (in fact, there was a
Jenkins automated test failure recently that caught #2, but item #4 is only
relevant on platforms where we don't do automated testing).  The tests
exercise the code paths for #1 and #3, but they do not catch these specific
cases currently.  


> topic/dnthayer/broctl-fixes
> ---------------------------
>
>                 Key: BIT-1087
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1087
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: BroControl
>            Reporter: Daniel Thayer
>             Fix For: 2.2
>
>
> This branch fixes several bugs in broctl:
> 1) on Linux, the broctl "top" command output sometimes shows wrong values for memory statistics,
> 2) there is a race condition when the "sendmail" option is an empty string,
> 3) there is a deadlock when broctl runs a local command that produces a sufficiently large amount of output,
> 4) the shell scripts used by broctl are not as portable as they could be (specifically, some commands, such as sed, do not support the same options on all implementations)



--
This message was sent by Atlassian JIRA
(v6.1-OD-09-WN#6144)


More information about the bro-dev mailing list