[Bro-Dev] [JIRA] (BIT-1047) Delete old scripts before installing new ones

[Jon Siwek (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304#comment-14304 ] 

Jon Siwek commented on BIT-1047:
--------------------------------

{quote}We should simply remove the old scripts/base and scripts/policy before installing anything new.{quote}

I have topic/jsiwek/remove-old-installed-scripts do this, but it doesn't get rid of the confusing error when upgrading a 2.1 install to 2.2:

{noformat}
fatal error in /usr/local/bro/share/bro/policy/frameworks/software/vulnerable.bro, line 41: BroType::AsRecordType (table/record) (set[record { min:record { major:count; minor:count; minor2:count; minor3:count; addl:string; }; max:record { major:count; minor:count; minor2:count; minor3:count; addl:string; }; }])
{noformat}

So the options there seem like either just document it in a how-to-upgrade doc or investigate a change in Bro to emit a more helpful error message.  Or both.  But I guess a lesson learned is to never have code directly in the distribution's version of local.bro, only {{@load}}'s.

The change in topic/jsiwek/remove-old-installed-scripts might still be helpful in other cases, but if you want it in before 2.2 final, having a couple other people test it would be nice to make sure it doesn't accidentally hose installs in some way.

> Delete old scripts before installing new ones
> ---------------------------------------------
>
>                 Key: BIT-1047
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1047
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>            Reporter: Robin Sommer
>             Fix For: 2.2
>
>
> People keep having problems when they install a new Bro version 
> over the installation of an old one because scripts that have disappeared in the new version will keep sticking around from the previous installation. 
> We should simply remove the old scripts/base and scripts/policy before installing anything new. People aren't supposed to edit in there so that should be safe.



--
This message was sent by Atlassian JIRA
(v6.1-OD-09-WN#6144)