[Bro-Dev] [JIRA] (BIT-1093) topic/jsiwek/thread-termination

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500#comment-14500 ] 

Robin Sommer commented on BIT-1093:
-----------------------------------

I looked up when the original "{{&& ! Killed()}}" code got introduced, that was in 743fc1680dc9d4c04f38ca80c7ef4e5b88e8f4cb and the commit message points to BIT-858. Can you take a look and double-check that the problem described there is still addressed with the new version to be sure we don't introduce a regression? (Not immediately sure if we have a test that covers that).

> topic/jsiwek/thread-termination
> -------------------------------
>
>                 Key: BIT-1093
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1093
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: Jon Siwek
>            Assignee: Robin Sommer
>             Fix For: 2.2
>
>
> The change in this branch should fix the case where the last remaining done/killed thread never got processed (main thread never received pending messages from it or joined/deleted it) until Bro terminates.  Which was problematic if the termination condition depended on processing messages from the last remaining thread.
> The new code's logic is contrary to what it used to be, but I can't figure out what the old was trying to accomplish and think it could only have caused problems.



--
This message was sent by Atlassian JIRA
(v6.2-OD-01#6204)