[Bro-Dev] [JIRA] (BIT-1183) topic/jsiwek/ascii-log-memleak-fix

[Jon Siwek (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200#comment-16200 ] 

Jon Siwek commented on BIT-1183:
--------------------------------

The second commit on this branch I think should resolve problems people have w/ increased memory usage over time on the manager.

The problem was this line: https://github.com/bro/bro/blob/a56c3437151985a1d0e4c881c047796109fbd81d/src/logging/writers/Ascii.cc#L158

At each rotation, that will add a new string that the Desc object has to check for when escaping strings.  Over time, the cost of escaping things in the ASCII logs will increase until the rate at which logs can be formatted/written is lower than the rate at which logs are produced.  Once that happens, Bro is unlikely to be able to catch up on the pending logs and so runs out of memory.

> topic/jsiwek/ascii-log-memleak-fix
> ----------------------------------
>
>                 Key: BIT-1183
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1183
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: Jon Siwek
>             Fix For: 2.3
>
>
> This branch fixes a memory leak in the ASCII log writer that occurs after each rotation.



--
This message was sent by Atlassian JIRA
(v6.3-OD-02-026#6318)