[Bro-Dev] [JIRA] (BIT-1185) topic/dnthayer/broctld-work

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206#comment-16206 ] 

Robin Sommer commented on BIT-1185:
-----------------------------------

> Added warning to do a "broctl install" if broctl or node config changes.

The code here looks a bit fragile to me as it depends on the right format being written out so that it can then later be reparsed. I'm wondering if we could just compute a hash of the two files instead and suggest a reinstall once that changes?
That would trigger on insignificant changes, too, like comments, but I don't think that would hurt much.

Also, the current code can miss some cases: like when a node gets removed, I don't think it will catch that (because it's not in the list of nodes iterated through in warnBroctlInstall().


> topic/dnthayer/broctld-work
> ---------------------------
>
>                 Key: BIT-1185
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1185
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: BroControl
>            Reporter: Daniel Thayer
>             Fix For: 2.3
>
>
> This branch contains some code cleanup and also fixes or improves the
> following issues:
> The df, exec, and top commands now run only once per host.
> Avoid reporting same disk check error msg multiple times for same host.
> Improve output column formatting.
> Added warning to do a "broctl install" if broctl or node config changes.
> Don't email about "$total" pseudo-node not receiving any packets.
> Remove unused "home" broctl option.
> Changed plugin API hosts() function to be more useful.



--
This message was sent by Atlassian JIRA
(v6.3-OD-02-026#6318)