[Bro-Dev] [JIRA] (BIT-1185) topic/dnthayer/broctld-work
Robin Sommer (JIRA)
jira at bro-tracker.atlassian.net
Tue Apr 22 20:36:07 PDT 2014
[ https://bro-tracker.atlassian.net/browse/BIT-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207#comment-16207 ]
Robin Sommer commented on BIT-1185:
A note for the future: I would prefer separate merge requests for individual features. Collecting multiple into one is fine if it's all just very small changes that each just touches a few lines, but this one has enough changes overall that it's getting tricky for me to follow which code change is associated with which semantic change (I'm usually looking at the whole diff between master and branch, not at individual commits inside the branch).
> Key: BIT-1185
> URL: https://bro-tracker.atlassian.net/browse/BIT-1185
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: BroControl
> Reporter: Daniel Thayer
> Fix For: 2.3
> This branch contains some code cleanup and also fixes or improves the
> following issues:
> The df, exec, and top commands now run only once per host.
> Avoid reporting same disk check error msg multiple times for same host.
> Improve output column formatting.
> Added warning to do a "broctl install" if broctl or node config changes.
> Don't email about "$total" pseudo-node not receiving any packets.
> Remove unused "home" broctl option.
> Changed plugin API hosts() function to be more useful.
This message was sent by Atlassian JIRA
More information about the bro-dev