[Bro-Dev] [JIRA] (BIT-1141) Investigate further improvements to file analysis performance

Robin Sommer (JIRA) jira at bro-tracker.atlassian.net
Thu Apr 24 16:00:07 PDT 2014


    [ https://bro-tracker.atlassian.net/browse/BIT-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221#comment-16221 ] 

Robin Sommer commented on BIT-1141:
-----------------------------------

Two questions:

(1)

{code}
typedef std::set<AcceptIdx> AcceptingSet;
typedef std::map<AcceptIdx, MatchPos> AcceptingMatchSet;
{code}

Did you change these to improve performance, or to simplify the code?
I'm actually wondering about performance here as set/map can potentially
be expensive in particular for small sizes (compared to using a vector
for example), and these will be instantiated and manipulated quite often.

(2)

Baseline/tests.m57-long/http.log: some MIME types change from
text/html to text/plain, is that expected?

> Investigate further improvements to file analysis performance
> -------------------------------------------------------------
>
>                 Key: BIT-1141
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1141
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>            Reporter: Robin Sommer
>            Assignee: Jon Siwek
>             Fix For: 2.3
>
>
> Some further ideas for measuring and improving the performance of maintaining the handles were floating around.  



--
This message was sent by Atlassian JIRA
(v6.3-OD-02-026#6318)


More information about the bro-dev mailing list