[Bro-Dev] [JIRA] (BIT-1141) Investigate further improvements to file analysis performance

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221#comment-16221 ] 

Robin Sommer edited comment on BIT-1141 at 4/24/14 6:15 PM:
------------------------------------------------------------

Two questions:

(1)

{code}
typedef std::set<AcceptIdx> AcceptingSet;
typedef std::map<AcceptIdx, MatchPos> AcceptingMatchSet;
{code}

I'm actually wondering about performance here as set/map can potentially
be expensive in particular for small sizes (compared to using a vector
for example), and these will be instantiated and manipulated quite often.

Put differently: I wouldn't be sure that using a set here is necessarily faster overall than a list as long as there's just a few elements in there. Were you able to confirm that?

(2)

Baseline/tests.m57-long/http.log: some MIME types change from
text/html to text/plain, is that expected? (Update: Ah, is that the bof_buffer_size change?)


was (Author: robin):
Two questions:

(1)

{code}
typedef std::set<AcceptIdx> AcceptingSet;
typedef std::map<AcceptIdx, MatchPos> AcceptingMatchSet;
{code}

I'm actually wondering about performance here as set/map can potentially
be expensive in particular for small sizes (compared to using a vector
for example), and these will be instantiated and manipulated quite often.

Put differently: I wouldn't be sure that using a set here is necessarily faster overall than a list as long as there's just a few elements in there. Were you able to confirm that?

(2)

Baseline/tests.m57-long/http.log: some MIME types change from
text/html to text/plain, is that expected?

> Investigate further improvements to file analysis performance
> -------------------------------------------------------------
>
>                 Key: BIT-1141
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1141
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>            Reporter: Robin Sommer
>            Assignee: Jon Siwek
>             Fix For: 2.3
>
>
> Some further ideas for measuring and improving the performance of maintaining the handles were floating around.  



--
This message was sent by Atlassian JIRA
(v6.3-OD-02-026#6318)