[Bro-Dev] [JIRA] (BIT-1231) DNP3 Analyzer Supports for DNP3-over-UDP
Robin Sommer (JIRA)
jira at bro-tracker.atlassian.net
Fri Aug 22 14:37:08 PDT 2014
[ https://bro-tracker.atlassian.net/browse/BIT-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605#comment-17605 ]
Robin Sommer commented on BIT-1231:
-----------------------------------
{quote}
For DNP3 over UDP analyzer. most of the codes are copied and pasted. Better way to reuse the code?
{quote}
Yeah, don't do that. :)
You need to refactor this out so that the code exists only once, probably by creating a joint base class or something (also applies to crc_table_initialized and crc_table).
> DNP3 Analyzer Supports for DNP3-over-UDP
> ----------------------------------------
>
> Key: BIT-1231
> URL: https://bro-tracker.atlassian.net/browse/BIT-1231
> Project: Bro Issue Tracker
> Issue Type: Improvement
> Components: Bro
> Affects Versions: 2.3
> Reporter: hui
> Assignee: Robin Sommer
> Labels: DNP3, analyzer
>
> Two major changes are made for the DNP3 analyzer
> 1. Make the analyzer support both the DNP3-over-UDP and the DNP3-over-TCP.
> The changes are made in DNP3.cc, DNP3.h and dpd.sig
> 2. Fix a bug in the binpac codes of the DNP3 analyzer
> The changes are made in dnp3-protocol.pac. The changes results in different baseline results of testing/btest/Baseline/scripts.base.protocols.dnp3.dnp3_link_only
>
--
This message was sent by Atlassian JIRA
(v6.4-OD-03-010#64001)
More information about the bro-dev
mailing list