[Bro-Dev] [JIRA] (BIT-1133) topic/jsiwek/dns-perf

[Jon Siwek (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549#comment-15549 ] 

Jon Siwek commented on BIT-1133:
--------------------------------

{quote}
Merged, with the expected result: time goes down. One "but" though: I still see a 2% increase in instructions for tests.m57-short and 1.5% for tests.m57-long, is there something else in DNS that's still quite a bit more expensive now?
{quote}

I didn't measure instructions, but I thought I didn't see any significant *timing* difference on m57-long.  There's extra conditional checks in some event handlers, there's extra events generated for unknown RR types, and there's extra weird events generated for unmatched messages, which could explain your observations.

Also, are you measuring -O2 or -O0; differences in the optimized version probably warrant more emphasis/interest, right?  But then that's also probably subject to more variance across arch/compiler (i.e. differing environments may make two people see differing perf changes) ?

> topic/jsiwek/dns-perf
> ---------------------
>
>                 Key: BIT-1133
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1133
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: Jon Siwek
>              Labels: dns, performance
>             Fix For: 2.3
>
>
> Refactored DNS script's state management to improve performance (due to reduced timer volume).
> Branch is in bro, bro-testing, bro-testing-private.



--
This message was sent by Atlassian JIRA
(v6.2-OD-09-036#6252)