[Bro-Dev] [JIRA] (BIT-1148) Bug in Connection::FlipRoles

[Jon Siwek (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709#comment-15709 ] 

Jon Siwek commented on BIT-1148:
--------------------------------

I have a patch for both issues in "topic/jsiwek/flip-roles", but it didn't trigger any differences in test suites, so I may try to come up with a test case.

> Bug in Connection::FlipRoles
> ----------------------------
>
>                 Key: BIT-1148
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1148
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: 2.2
>            Reporter: Jon Siwek
>             Fix For: 2.3
>
>
> This method doesn't correctly swap address values.
> Also, since scheduled analyzers for a connection are looked up based on the endpoint addresses, it's possible they will miss being attached to connections that end up taking the Connection::FlipRoles code path.  An idea to fix would be just to have FlipRoles do a check for scheduled analyzers on the new connection tuple and attach any that turn up.
> (These were reported by Kevin McMahon on the bro-dev list).



--
This message was sent by Atlassian JIRA
(v6.2-OD-10-004-WN#6253)