[Bro-Dev] [JIRA] (BIT-1134) DNS_Mgr::LookupAddr does not respect DNS_FAKE

Robin Sommer (JIRA) jira at bro-tracker.atlassian.net
Thu Mar 13 14:34:18 PDT 2014


    [ https://bro-tracker.atlassian.net/browse/BIT-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725#comment-15725 ] 

Robin Sommer commented on BIT-1134:
-----------------------------------

Merging. I'm suggesting a further change though: what do you think about making the fake values deterministic based on the queries? E.g., BuildFakeNameResult(ip) could return "fake_<ip>" and BuildFakeAddrResult(name)  an address derived from hash(name).

Advantage: now that the test-suite runs in DNS_FAKE mode, changes that affect DNS resolution wouldn't trigger diffs.

> DNS_Mgr::LookupAddr does not respect DNS_FAKE
> ---------------------------------------------
>
>                 Key: BIT-1134
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1134
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: 2.2
>            Reporter: Justin Azoff
>            Assignee: Jon Siwek
>            Priority: Low
>             Fix For: 2.3
>
>         Attachments: signature.asc
>
>




--
This message was sent by Atlassian JIRA
(v6.2-OD-10-004-WN#6253)


More information about the bro-dev mailing list