[Bro-Dev] [JIRA] (BIT-1154) Formatters restructed in: topic/seth/json-formatter

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728#comment-15728 ] 

Robin Sommer commented on BIT-1154:
-----------------------------------

Merged. 

The tests are a bit on the weak side though ... I'm leaving the ticket open hoping that we can add a few more:

    - More extensive tests of the JSON output (though I realize that's not quite trivial as the JSON output requires some normalization to diff larger log volumes)
    
   - I don't think there's any test of the new per-filter config options?

Also, it might be nice to format the JSON a bit prettier, like with some more white space?

> Formatters restructed in: topic/seth/json-formatter
> ---------------------------------------------------
>
>                 Key: BIT-1154
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1154
>             Project: Bro Issue Tracker
>          Issue Type: New Feature
>          Components: Bro
>    Affects Versions: 2.3
>            Reporter: Seth Hall
>            Assignee: Robin Sommer
>
> topic/seth/json-formatter has an abstraction for Formatters and I created a formatters directory under threading.  There is also a new JSON formatter and support in the Ascii and ElasticSearch writers for the JSON formatter.
> I went ahead and threw in per-filter configuration options for the Ascii writer for all of the options that were exposed globally too.



--
This message was sent by Atlassian JIRA
(v6.2-OD-10-004-WN#6253)