[Bro-Dev] [JIRA] (BIT-1134) DNS_Mgr::LookupAddr does not respect DNS_FAKE

[Jon Siwek (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732#comment-15732 ] 

Jon Siwek commented on BIT-1134:
--------------------------------

Technically, I'm not sure it's actually an advantage in terms of less test suite diffs getting triggered because I think output will always be deterministic and based on the order in which lookups are executed (fake results are available immediately, so callbacks are always executed in order and given the same fake result value across runs).  If fake result values are derived from the input, test baselines still change under the same circumstances -- when Bro scripts change the order in which lookup_* builtins are invoked.  Or is there something else I'm not getting about it?

Practically, having the fake results derived from the input does probably make output easier to follow for a human inspector.

> DNS_Mgr::LookupAddr does not respect DNS_FAKE
> ---------------------------------------------
>
>                 Key: BIT-1134
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1134
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: 2.2
>            Reporter: Justin Azoff
>            Assignee: Jon Siwek
>            Priority: Low
>             Fix For: 2.3
>
>         Attachments: signature.asc
>
>




--
This message was sent by Atlassian JIRA
(v6.2-OD-10-004-WN#6253)