[Bro-Dev] [JIRA] (BIT-1134) DNS_Mgr::LookupAddr does not respect DNS_FAKE

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735#comment-15735 ] 

Robin Sommer commented on BIT-1134:
-----------------------------------

If just order changes, or say new lookups get introduced, the output
wouldn't change if we derive the fake results directly from the
queries. If the input changes to trigger different queries, we'd still
get diffs but maybe they would now affect only a subset of the test
run's output, not all subsequent lookups. In other words, I think this
would reduce the likelihood and volume of diffs, but it can't fiully
avoid them of course.

{quote}
Practically, having the fake results derived from the input does probably make output easier to follow for a human inspector.
{quote}

Ack.


> DNS_Mgr::LookupAddr does not respect DNS_FAKE
> ---------------------------------------------
>
>                 Key: BIT-1134
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1134
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: 2.2
>            Reporter: Justin Azoff
>            Assignee: Jon Siwek
>            Priority: Low
>             Fix For: 2.3
>
>         Attachments: signature.asc
>
>




--
This message was sent by Atlassian JIRA
(v6.2-OD-10-004-WN#6253)