[Bro-Dev] [Bro-Commits] [git/bro] topic/jsiwek/pktsrc-idle: Fix packet sources being treated as idle when a packet is available. (31b7e98)
jsiwek at illinois.edu
Thu Oct 2 12:41:34 PDT 2014
Yeah, if it reports itself as idle while a packet was just retrieved, then whether or not it’s actually a candidate to be Process()’d can depend on the result of a subsequent select() — seems problematic :)
On Oct 2, 2014, at 2:34 PM, Robin Sommer <robin at icir.org> wrote:
> Never mind, I see that's there already.
> On Thu, Oct 02, 2014 at 11:48 -0700, I wrote:
>> On Thu, Oct 02, 2014 at 11:25 -0700, Jonathan Siwek wrote:
>>> + SetIdle(false);
>> The 2.1 code was also doing the opposite: setting to true if we have a
>> packet. Not immediately sure if that's necessary.
> Robin Sommer * Phone +1 (510) 722-6541 * robin at icir.org
> ICSI/LBNL * Fax +1 (510) 666-2956 * www.icir.org/robin
> bro-commits mailing list
> bro-commits at bro.org
More information about the bro-dev