[Bro-Dev] [Bro-Commits] [git/bro] topic/jsiwek/pktsrc-idle: Fix packet sources being treated as idle when a packet is available. (31b7e98)
Robin Sommer
robin at icir.org
Thu Oct 2 13:05:25 PDT 2014
(I had mixed up the cases in my mail :)
On Thu, Oct 02, 2014 at 19:41 +0000, Jonathan Siwek wrote:
> Yeah, if it reports itself as idle while a packet was just retrieved, then whether or not it’s actually a candidate to be Process()’d can depend on the result of a subsequent select() — seems problematic :)
>
> - Jon
>
> On Oct 2, 2014, at 2:34 PM, Robin Sommer <robin at icir.org> wrote:
>
> > Never mind, I see that's there already.
> >
> > Robin
> >
> > On Thu, Oct 02, 2014 at 11:48 -0700, I wrote:
> >
> >>
> >>
> >> On Thu, Oct 02, 2014 at 11:25 -0700, Jonathan Siwek wrote:
> >>
> >>> + SetIdle(false);
> >>
> >> The 2.1 code was also doing the opposite: setting to true if we have a
> >> packet. Not immediately sure if that's necessary.
> >>
> >> Robin
> >>
> >
> >
> > --
> > Robin Sommer * Phone +1 (510) 722-6541 * robin at icir.org
> > ICSI/LBNL * Fax +1 (510) 666-2956 * www.icir.org/robin
> > _______________________________________________
> > bro-commits mailing list
> > bro-commits at bro.org
> > http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-commits
> >
>
>
--
Robin Sommer * Phone +1 (510) 722-6541 * robin at icir.org
ICSI/LBNL * Fax +1 (510) 666-2956 * www.icir.org/robin
More information about the bro-dev
mailing list