[Bro-Dev] [JIRA] (BIT-1270) topic/gilbert/plugin-api-tweak

[Jon Siwek (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18410#comment-18410 ] 

Jon Siwek commented on BIT-1270:
--------------------------------

Whether to pass by value and whether to use ValWrapper vs. std::pair seem like separate issues/suggestions?

I'd also make the suggestion to pass by value.  Whether that value is ValWrapper or std::pair I don't have a good feel for without reviewing the code more.  Maybe std::pair if it's used infrequently else ValWrapper just to be able to chose the names of the fields (reading/writing code that uses "x.first" and "x.second" can get confusing for me personally).

(And std::tuple is C++11, right?  Did we decide that's generally ok to use in Bro now?)

> topic/gilbert/plugin-api-tweak
> ------------------------------
>
>                 Key: BIT-1270
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1270
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>            Reporter: gclark
>            Assignee: gclark
>
> This branch makes a few changes to the API:
> * Wraps values in a simple class (ValWrapper) that include an explicit processed / not processed flag (to avoid confusion with delayed / opaque invocations).
> * Adds a Frame argument to HookCallFunction
> * Adds support for Frame argument types to HookArgument
> * Adds support for ValWrapper argument types to HookArgument
> * Tweaks the plugin.hooks tests a bit to include new output (from additional argument)
> * Tweaks the plugin.api-version-mismatch to remove explicit home directory path via simple regex



--
This message was sent by Atlassian JIRA
(v6.4-OD-07-004#64005)