[Bro-Dev] [JIRA] (BIT-1250) topic/jsiwek/jj-bugs

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016#comment-18016 ] 

Robin Sommer commented on BIT-1250:
-----------------------------------

Merged, but two questions:

    - HTTP_Message::entity_data_buffer: that's allocated with every
      HTTP message. Would there be any benefit to allocate it only on
      demand when it's actually used? I can't immediately tell if the
      buffer is indeed going to be accessed generally with every message, or
      only sometimes.

    - I'm seeing somewhat longer execution times:

      {noformat}
      [ 28%] tests.m57-short ... failed (+1.0%)
      [ 50%] tests.short ... failed (+1.5%)
      [ 75%] tests.medium ... failed (+1.4%)
      {noformat}

      Could this even be related to that buffer above?

      Oddly enough, I'm seeing *better* times for the v6 trace:

      {noformat}
      [ 71%] tests.ipv6 ... failed (-1.5%)
      {noformat}

      (These failures are consistent across multiple runs; sometimes I get
      false alarms with the timing measurements, but normally they
      disappear on reruns.)

Closing the individual tickets but leaving this ticket open for now.
Please check and close if everything looks good / you can't reproduce
the timing differences.

> topic/jsiwek/jj-bugs
> --------------------
>
>                 Key: BIT-1250
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1250
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: Jon Siwek
>             Fix For: 2.4
>
>
> This branch is in bro, bro-testing, and bro-testing-private repos, fixing problems reported in BIT-1240, BIT-1246, BIT-1247, and BIT-1248.



--
This message was sent by Atlassian JIRA
(v6.4-OD-04-006#64001)