[Bro-Dev] [JIRA] (BIT-1250) topic/jsiwek/jj-bugs

Jon Siwek (JIRA) jira at bro-tracker.atlassian.net
Mon Sep 15 11:43:07 PDT 2014

    [ https://bro-tracker.atlassian.net/browse/BIT-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101#comment-18101 ] 

Jon Siwek commented on BIT-1250:

HTTP_Message::entity_data_buffer: that's allocated with every
HTTP message. Would there be any benefit to allocate it only on
demand when it's actually used? I can't immediately tell if the
buffer is indeed going to be accessed generally with every message, or
only sometimes.

Good point. It is only used sometimes.

I'm seeing somewhat longer execution times:
Could this even be related to that buffer above?

Doing some quick timings of test.medium I got a similar result: +1.6%.  Changing that buffer to be allocated on-demand seemed to make the difference negligible, so I think that explains it.  And IIRC, the original code also did allocation on-demand.  I'll commit the change to master.

> topic/jsiwek/jj-bugs
> --------------------
>                 Key: BIT-1250
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1250
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: Jon Siwek
>             Fix For: 2.4
> This branch is in bro, bro-testing, and bro-testing-private repos, fixing problems reported in BIT-1240, BIT-1246, BIT-1247, and BIT-1248.

This message was sent by Atlassian JIRA

More information about the bro-dev mailing list