[Bro-Dev] [JIRA] (BIT-1260) topic/jsiwek/improve_comm_loop

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18209#comment-18209 ] 

Robin Sommer commented on BIT-1260:
-----------------------------------

Nice idea with the Flares. Merged, but questions:

- the pipe operations in the Flare methods worry me: shouldn't unexpected errors lead to abort, rather than potential endless loops?

- I'm confused about the precise semantics ExtraReadFDs(): it says *Read*, but ChunkedIOFD also adds the write flare, but ChunkedIOSSL doesn't?

- API suggestion: can we give ChunkedIO just a single method FDs() that combines Fd() and ExtraReadFDs()?

Leaving open for now.

> topic/jsiwek/improve_comm_loop
> ------------------------------
>
>                 Key: BIT-1260
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1260
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>            Reporter: Jon Siwek
>             Fix For: 2.4
>
>
> This branch removes timeouts from the remote communication loop and so reduces cpu usage during the times it's supposed to be idle.



--
This message was sent by Atlassian JIRA
(v6.4-OD-05-009#64003)