[Bro-Dev] [JIRA] (BIT-1371) check-cmake causes make-rpm-packages to fail

[Jon Siwek (JIRA)]

     [ https://bro-tracker.atlassian.net/browse/BIT-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Siwek updated BIT-1371:
---------------------------
    Resolution: Fixed
        Status: Closed  (was: Open)

I just removed the version check.  I originally intended these scripts to just be for internal use on a very limited set of target platforms and Bro's binary packaging will eventually be done differently:

http://mailman.icsi.berkeley.edu/pipermail/bro-dev/2015-February/009111.html

You might want to check that out (but the CPack/CMake-based build scripts in the pkg/ dir will still probably stick around until they break somehow and there's no one around that feels like maintaining them anymore).

> check-cmake causes make-rpm-packages to fail
> --------------------------------------------
>
>                 Key: BIT-1371
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1371
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: 2.3
>         Environment: CentOS 7 x64
>            Reporter: Chris Fowler
>            Assignee: Jon Siwek
>             Fix For: 2.4
>
>
> Attempting to use pkg/make-rpm-packages to build packages on CentOS 7 fails since the pkg/check-cmake script is just checking for an exact match to the version string. CentOS 7's version of cmake (2.8.11) is newer than the one being checked for (2.8.6) and will correctly work for building the packages, but this:
> bq. #!/bin/sh
> bq. 
> bq. CMAKE_PACK_REQ="cmake version 2.8.6"
> bq. CMAKE_VER=`cmake -version`
> bq. 
> bq. if [ "${CMAKE_VER}" != "${CMAKE_PACK_REQ}" ]; then
> bq.     echo "Package creation requires ${CMAKE_PACK_REQ}" >&2
> bq.     exit 1
> bq. fi
> will not allow newer versions to be used without bypassing the check.



--
This message was sent by Atlassian JIRA
(v6.4-OD-16-006#64014)