[Bro-Dev] [JIRA] (BIT-1455) topic/dnthayer/py3-compat

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21714#comment-21714 ] 

Robin Sommer commented on BIT-1455:
-----------------------------------


> The 4 test failures in the Bro repo are expected 

Ah, I saw the commit, but didn't make the connection to these tests. Can you see if you can fix them?

> Could you give me more info about what you're seeing?

Not much more than what I wrote unfortunately. Here's what it looks like:

{noformat}
> .btest -dv tests/measure-time-options.test
tests.measure-time-options ...
  > test "`uname`" = "Linux"
  > which perf
  > perf stat -o /dev/null true 2> /dev/null
  > perf stat -x " " -e instructions true 2>&1  | grep -vq "not supported"
  > test -f btest.cfg || cp /home/robin/bro/master/aux/btest/testing/btest.tests.cfg btest.cfg; echo >/dev/null tests.measure-time-options
  > btest -D %INPUT >>output 2>&1
  > echo ----- >>output
  > test '!' -e Baseline/_Timing
  > test '!' -e mytimings
  > btest -DT %INPUT >>output 2>&1
... tests.measure-time-options failed
  % 'btest -DT /home/robin/bro/master/aux/btest/testing/.tmp/tests.measure-time-options/measure-time-options.test >>output 2>&1' failed unexpectedly (exit code 1)
  % cat .stderr

1 of 1 test failed
../testing> cat .tmp/tests.measure-time-options/.tmp/measure-time-options/.stderr
Usage: awk [POSIX or GNU style options] -f progfile [--] file ...
Usage: awk [POSIX or GNU style options] [--] 'program' file ...
POSIX options:          GNU long options: (standard)
        -f progfile             --file=progfile
        -F fs                   --field-separator=fs
[rest of the usage message]
{noformat}

Fore debugging I replaced the awk with something else just recording arguments and it's indeed just being called without any of them, which triggers the usage message.


> topic/dnthayer/py3-compat
> -------------------------
>
>                 Key: BIT-1455
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1455
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: BTest
>            Reporter: Daniel Thayer
>            Assignee: Daniel Thayer
>             Fix For: 2.5
>
>         Attachments: diag.log
>
>
> The branch topic/dnthayer/py3-compat in the btest repo contains the
> following changes:
> 1) update btest to work on Python 3 (still works with Python 2.6 and 2.7)
> 2) fixed two bugs in btest-diff that could result in a failing test that appears to succeed
> 3) add more test cases
> 4) fix measure-time test to not be skipped on some systems that have all prereqs
> 5) fixed a test that set TEST_DIFF_CANONIFIER to wrong path
> 6) improvements to the README



--
This message was sent by Atlassian JIRA
(v7.0.0-OD-01-193#70101)