[Bro-Dev] [Bro-Commits] [git/bro] topic/jsiwek/socks-authentication: Refactor SOCKS5 user/pass authentication support. (961fd06)

[Seth Hall]

> On Feb 13, 2015, at 5:42 AM, Siwek, Jon <jsiwek at illinois.edu> wrote:
> 
> The definition of SOCKS5 in RFC 1928 doesn’t seem to say anything about what different authentication methods should do.  So RFC 1929 for username/password has a reply w/ [version octet, status octet] and RFC 1961 for GSSAPI has [version octet, message type octet, length octet, variable length opaque token].

Ah, ok.  I didn’t follow the RFC down far enough apparently.  Thanks.

It looks good to me.

  .Seth

--
Seth Hall
International Computer Science Institute
(Bro) because everyone has a network
http://www.bro.org/