[Bro-Dev] [JIRA] (BIT-1437) broctl doesn't handle a missing broctl-config.sh well

[Johanna Amann (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21401#comment-21401 ] 

Johanna Amann commented on BIT-1437:
------------------------------------

Actually - you might have misunderstood me there -- the broken symlink is by default present after a bro make install.

Packaging utilities often refuse to ship broken symlinks -- which requires the manual fix to make it appear in a system exactly as it does after a bro "make install". I assume the same thing happens with homebrew.

In any case, needing a broken symlink is kind of awkward in any case.

Johanna

> broctl doesn't handle a missing broctl-config.sh well
> -----------------------------------------------------
>
>                 Key: BIT-1437
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1437
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: BroControl
>    Affects Versions: git/master
>            Reporter: Justin Azoff
>            Assignee: Daniel Thayer
>
> On a few install from homebrew, this happens:
> {code}
> [BroControl] > install
> removing old policies in /usr/local/Cellar/bro/2.4/spool/installed-scripts-do-not-touch/site ...
> removing old policies in /usr/local/Cellar/bro/2.4/spool/installed-scripts-do-not-touch/auto ...
> creating policy directories ...
> installing site policies ...
> generating standalone-layout.bro ...
> generating local-networks.bro ...
> generating broctl-config.bro ...
> generating broctl-config.sh ...
> Error: failed to resolve symlink '/usr/local/Cellar/bro/2.4/share/broctl/scripts/broctl-config.sh': No such file or directory
> {code}
> Broctl assumes that broctl-config.sh will always exist. Apparently the other binary bro packages have workarounds to ship an initially broken symlink for this file.  We could probably work around this for homebrew, but I think I have a fix that will just ignore a missing file initially.



--
This message was sent by Atlassian JIRA
(v6.5-OD-08-001#65007)